OIiveirra commented on code in PR #69032:
URL: https://github.com/apache/doris/pull/69032#discussion_r4623419189


##########
be/src/core/data_type_serde/data_type_varbinary_serde.cpp:
##########
@@ -67,23 +82,37 @@ class VarbinaryParquetConsumer final : public 
ParquetFixedValueConsumer,
     }
 
 private:
-    ColumnVarbinary& _column;
+    ColumnType& _column;
 };
 
+class VarbinaryParquetConsumer final : public 
BinaryParquetConsumerBase<ColumnVarbinary> {
+public:
+    using 
BinaryParquetConsumerBase<ColumnVarbinary>::BinaryParquetConsumerBase;
+};
+
+class GeoParquetConsumer final : public 
BinaryParquetConsumerBase<ColumnSpatial> {

Review Comment:
   主要是为了复用 Parquet 的二进制读取逻辑,空间列存的是 WKB 字节,读出来直接写进 ColumnSpatial,再由空间类型自己的 SerDe 
校验,感觉可以去掉两个空子类,直接用 BinaryParquetConsumer<ColumnType>,WKB 校验继续由 
SpatialParquetSerDe 负责



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to