[GitHub] [doris] HappenLee commented on a diff in pull request #16943: [fix](value-range) fix the value range of non-nullable column contains null causes query short key index error.

[via GitHub]

HappenLee commented on code in PR #16943:
URL: https://github.com/apache/doris/pull/16943#discussion_r1116960282


##########
be/src/exec/olap_common.h:
##########
@@ -312,13 +317,13 @@ class ColumnValueRange {
         _high_value = TYPE_MAX;
         _low_op = FILTER_LARGER_OR_EQUAL;
         _high_op = FILTER_LESS_OR_EQUAL;
-        _contain_null = true;
+        _contain_null = _is_nullable_col;
     }
 
     bool is_whole_value_range() const {
         return _fixed_values.empty() && _low_value == TYPE_MIN && _high_value 
== TYPE_MAX &&
                _low_op == FILTER_LARGER_OR_EQUAL && _high_op == 
FILTER_LESS_OR_EQUAL &&
-               contain_null();
+               _is_nullable_col == contain_null();

Review Comment:
   which case `_is_nullable_col` = false and  `contain_null()` = true



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org