wyxxxcat commented on PR #70225:
URL: https://github.com/apache/doris/pull/70225#issuecomment-6973592286
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#70225
commit: 3cbcea8d755fb110a830c90153cab121001daeff
base: 4a3fce2a8fc1000b90f14793241aeeb574402e7e
reviewed_at: 2026-11-18T16:47+08:00
reviewer: wyxxxcat
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 3, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
- **F-01 (Minor, observability regression)**
`cloud/src/recycler/recycler.cpp:2667-2669` and `6837-6839`. If the separate
ref-count cleanup fails after the tmp-key deletion commits, the deleted keys
are permanently undercounted. Record the count immediately after the tmp-key
commit in both paths.
- **F-02 (Minor, observability regression)**
`cloud/src/recycler/recycler.h:221-224`. Moving last-round byte reporting to
`finish_report()` drops the existing byte metric for `recycle_ref_rowsets`,
whose per-tablet contexts only call `report()`. Call `finish_report()` when
that cleanup scope ends.
- **F-03 (Minor, observability regression)**
`cloud/src/recycler/recycler.h:255-258`. The operation-log callback leaves the
new scanned and expired counters at zero, so the three progress metrics can
report `(0, 0, 1)` after deleting one eligible log. Populate both counters in
`recycler_operation_log.cpp:807-852`.
- Static review covered all four changed files and converged in one round.
The review scope excluded transient metric discrepancies from concurrent
reporting. No build or tests were run.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]