morningman opened a new pull request, #70712:
URL: https://github.com/apache/doris/pull/70712

   ### Background
   
   The reviewer assignment workflow selects candidates with a read-only job, 
then uses a separate job to add assignees, post comments and finalize labels. 
Both jobs use trusted base-branch code and the repository GITHUB_TOKEN.
   
   ### What problem does this PR solve?
   
   Issue Number: None
   Related PR: #70695 (introduced the workflow), #70665 (affected PR)
   PR Type: Build/CI/Chore
   
   Problem Summary:
   
   The [assignment run for 
#70665](https://github.com/apache/doris/actions/runs/44249677185/job/134617789765)
 failed when creating its initial PR comment: `403 Resource not accessible by 
integration`. The token had `issues: write` but only `pull-requests: read`. 
Grant PR write permission to the final assignment job and update the existing 
permission-boundary test to allow it only there.
   
   ### Details
   
   - **Affected:** The `assign` job in `reviewer-assignment.yml` on 
GitHub-hosted Ubuntu runners, and its existing workflow test.
   - **Developer and release impact:** Enables the assignment job to write PR 
comments and complete reviewer assignment. Doris builds, runtime behavior and 
release procedures are unchanged.
   - **License and third-party:** None.
   - **Rollback:** Revert this commit; no secrets, caches or runner 
configuration need changes.
   - **CI permissions and secrets:** Only `assign` gains `pull-requests: write` 
for its PR mutations. Selection remains read-only, write steps execute trusted 
base-branch code, and no new secrets or token types are introduced.
   
   ### Testing
   
   - Locally on macOS, the updated permission-boundary test failed against the 
original workflow and passed after the permission change.
   - `PYTHONDONTWRITEBYTECODE=1 python3 -m unittest discover -s .github/scripts 
-p test_reviewer_assignment.py`: all 106 tests passed.
   - The hosted assignment flow has not been rerun with the new permissions; 
that verification requires the workflow change on the target branch.
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Behavior changed: No
   - Does this need documentation: No
   - Pre-submission status: Partially verified: local tests passed; the hosted 
PR comment write still needs validation after the workflow is updated.
   
   ### AI Disclosure
   
   - Tool: Codex (GPT-6).
   - Generated: Workflow permission change, existing test adjustment and this 
description.
   - Human review: Not stated.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to