This is an automated email from the ASF dual-hosted git repository.

morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
     new fbb96f24ad8 [chore](build) Clarify where to load Doris development 
skills (#70672)
fbb96f24ad8 is described below

commit fbb96f24ad8a11c0ad00ac4b410e266a2dd651c1
Author: Mingyu Chen (Rayner) <[email protected]>
AuthorDate: Tue Nov 17 17:13:29 2026 +0800

    [chore](build) Clarify where to load Doris development skills (#70672)
    
    ### Background
    
    `AGENTS.md` guides agents working in Doris checkouts and worktrees. The
    repository includes reusable development and PR-writing workflows in the
    `doris-skills` submodule, which worktree setup leaves uninitialized by
    default.
    
    ### What problem does this PR solve?
    
    Issue Number: None
    Related PR: None
    PR Type: Build/CI/Chore
    
    Problem Summary:
    
    `AGENTS.md` references `develop-with-evidence` and
    `doris-pr-description` without saying where to find them, and its
    submodule rule only accounts for builds and tests. Document
    `doris-skills/skills/develop-with-evidence/SKILL.md` and
    `doris-skills/skills/doris-pr-description/SKILL.md` as their entry
    points in the current worktree, and require a scoped submodule update
    before loading a missing skill.
    
    ### Details
    
    - **Affected:** Agent workflow instructions in `AGENTS.md` for Doris
    checkouts and worktrees.
    - **Developer and release impact:** Agents initialize `doris-skills`
    when needed and read the skill instructions from the current worktree.
    The release process is unchanged.
    - **License and third-party:** None.
    - **Rollback:** Revert this change.
    
    ### Testing
    
    Executed `git submodule update --init -- doris-skills` locally on macOS
    and confirmed that `doris-skills/skills/develop-with-evidence/SKILL.md`
    and `doris-skills/skills/doris-pr-description/SKILL.md` are present. No
    build or runtime tests were run for this documentation-only change.
---
 AGENTS.md | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/AGENTS.md b/AGENTS.md
index b16c7f794e2..c6859af9799 100644
--- a/AGENTS.md
+++ b/AGENTS.md
@@ -26,7 +26,14 @@ Every change under `gensrc/thrift` and `gensrc/proto` must 
keep every upgrade co
 
 To ensure smooth test execution without interference between worktrees, the 
first thing to do upon entering a worktree directory is to check if 
`.worktree_initialized` exists. If not, execute `hooks/setup_worktree.sh`, 
setting `$ROOT_WORKSPACE_PATH` to the base directory (typically 
`${DORIS_REPO}`) beforehand. After successful execution, verify that 
`.worktree_initialized` has been touched and that `thirdparty/installed` 
dependencies exist correctly.
 
-Submodules are not part of the default worktree setup. If the task does not 
compile Doris or run tests that require submodules, leave all submodules 
uninitialized. Build and test entry points initialize the submodule paths they 
require. Only initialize a submodule manually when the task actually needs it 
and an entry point does not handle it; initialize the exact required path 
instead of running an unscoped recursive update for every submodule.
+Submodules are not part of the default worktree setup. If the task does not 
need submodule content for builds, tests, or skills, leave all submodules 
uninitialized. Build and test entry points initialize the submodule paths they 
require. Only initialize a submodule manually when the task actually needs it 
and an entry point does not handle it; initialize the exact required path 
instead of running an unscoped recursive update for every submodule.
+
+The `develop-with-evidence` and `doris-pr-description` skills must be loaded 
from the `doris-skills/` submodule in the current worktree:
+
+- `develop-with-evidence`: `doris-skills/skills/develop-with-evidence/SKILL.md`
+- `doris-pr-description`: `doris-skills/skills/doris-pr-description/SKILL.md`
+
+If the submodule is uninitialized or either required skill is missing, first 
run `git submodule update --init -- doris-skills` from the worktree root to 
fetch or update it. Then read the corresponding `SKILL.md` at the path above 
before using the skill.
 
 When working in worktree mode, all operations must be confined to the current 
worktree directory. Do not enter `${DORIS_REPO}` or use any resources there. 
Git's own storage in `${DORIS_REPO}/.git`, which every worktree shares, is not 
such a resource. This includes the PR handoff files in 
`${DORIS_REPO}/.git/pr-handoff/`, which a development skill such as 
`develop-with-evidence` writes and the `doris-pr-description` skill reads. 
Compilation and execution must be done within the current wo [...]
 


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to