github-actions[bot] commented on code in PR #70661:
URL: https://github.com/apache/doris/pull/70661#discussion_r4597054547
##########
be/src/exec/runtime_filter/runtime_filter_mgr.cpp:
##########
@@ -589,11 +589,7 @@ Status
RuntimeFilterMergeControllerEntity::merge(std::shared_ptr<QueryContext> q
RETURN_IF_ERROR(tmp_filter->assign(*request, attach_data));
- // `tmp_filter` is created solely to carry this one RPC's filter into
the merger and is
- // discarded right after; nothing else reads its wrapper, so the
merger may take it over
- // without a copy.
- RETURN_IF_ERROR(cnt_val.merger->merge_from(tmp_filter.get(), &is_ready,
-
/*other_wrapper_exclusively_owned=*/true));
+ RETURN_IF_ERROR(cnt_val.merger->merge_from(tmp_filter.get(),
&is_ready));
Review Comment:
[P1] Do not count a failed RPC clone as a received filter
The new mandatory copy can fail after `RuntimeFilterMerger::merge_from`
increments `_received_producer_num`, leaving its wrapper `UNINITED`. For a
non-broadcast `IN_OR_BLOOM` filter with `build_bf_by_runtime_size=false`,
`ignore_runtime_filter_error=true` and `enable_reserve_memory=false`, the first
BE's large Bloom can fit deserialization but exceed the query limit when its
directory is cloned. That error only gets logged; the input temporary is freed
while the received count stays 1. A second BE's small IN set can then fit,
reach the expected count of 2, and cause `_send_rf_to_target` to publish only
that set, rejecting valid rows represented by the omitted Bloom. Mixed
representations are reachable when size sync is disabled or the join has
multiple equality conjuncts. The previous exclusive RPC path adopted the first
wrapper without this allocation. Prevent failed accumulation from making a
partial result publishable, for example by disabling the merger on error or
committing
count/readiness only after successful accumulation, and add a failed-copy
regression for ignore mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]