englefly opened a new pull request, #70663: URL: https://github.com/apache/doris/pull/70663
### Background TPC-DS and TPC-H tools are built from the upstream TPC-DS 3.2.0 and TPC-H 3.0.0 source archives. ### What problem does this PR solve? Issue Number: None Related PR: None PR Type: Bugfix Problem Summary: GCC 15 rejects legacy function declarations and definitions in the TPC-DS and TPC-H sources. Select GNU89 for both builds so the generator compiles. ### Details - Frequency: Reproducible with GCC 15.2.0. - Root cause: The compiler default dialect no longer accepts the source's legacy function definitions. - Why existing tests missed it: The script does not pin the C dialect, so compatibility depends on the host compiler. - Fix: Explicitly select GNU89 while retaining the upstream build flags. - Other paths and branches: TPC-DS selects the dialect in its Linux flags; TPC-H adds it to the generated makefile. ### Testing Reproduced the original failure with GCC 15.2.0. Ran bash -n and git diff --check. Built TPC-DS from a fresh extraction and TPC-H after make clean using the modified scripts. Generated 20 income_band rows with dsdgen and 5 region rows with dbgen. ### Release note TPC-DS and TPC-H tools can now be built with GCC 15. ### Check List (For Author) - Behavior changed: No - Does this need documentation: No - Pre-submission status: Ready ### AI Disclosure - Tool: Codex - Generated: Both script changes and commit description. - Human review: Pending. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
