CalvinKirs commented on PR #70434: URL: https://github.com/apache/doris/pull/70434#issuecomment-6936317196
Local review result: **APPROVE** — no remaining findings (Blocker: 0, Major: 0, Minor: 0, Nit: 0). Reviewed commit: `fc6a74ca49421d270060349341284d30c4c47396`. Baseline: `5e85976d4c58d5528cb49d3ef677d5e695c2a36d`, the exact master revision merged by failed FEUT build 4833. The review covered the complete six-file patch, with independent Java and regression/composition reviews; it converged in one round at this head. - The three new UT failures came from expecting an extra Filter layer after #70409 made `PlanUtils` merge adjacent filters. - Updated assertions retain exact predicate placement, original volatile ON expressions, and output-column checks. Explicit Filter-chain inputs preserve root/recursive extraction coverage independently of `PlanUtils` normalization; repeated extraction now checks full-tree stability with `deepEquals`. - This follow-up changes only `ReorderJoinTest`; the production changes, shared-helper test and SQL fixtures are unchanged from the previously reviewed PR head. The earlier volatile-ON guard finding remains fixed. Validation on that CI master baseline plus the fix: - **56 targeted FE unit tests passed**, with zero failures, errors or skips: `ReorderJoinTest`, `MergeFiltersTest`, `PlanUtilsTest`, `InferAggNotNullTest`, `PushDownFilterThroughJoinTest`, `PushFilterInsideJoinTest`, and `FindHashConditionForJoinTest`. - **FE Core Checkstyle passed**, with zero violations. The complete FEUT suite and SQL/full EXPLAIN-shape regression were not rerun locally. The previous guard-removal negative control is historical evidence, not a new execution at this head. A new `run buildall` has been requested; the full CI result is pending. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
