jacktengg commented on PR #70485:
URL: https://github.com/apache/doris/pull/70485#issuecomment-6923871945

   <!-- doris-repo-review:v1:begin -->
   ### Local pipeline review — ✅ PASS
   
   ```yaml
   schema: doris-repo-review/v1
   status: PASS
   pr: apache/doris#70485
   commit: ccc8288372868ad611dd2e38a0c5aef260463533
   base: d7c0fb9427b005eb5ab8b9e0eb6592dd89964fc1
   reviewed_at: 2026-11-17T01:27+08:00
   reviewer: jacktengg
   model: gpt-6-astra
   effort: xhigh
   findings: {blocker: 0, major: 0, minor: 1, nit: 0}
   rounds: 1
   converged: true
   ```
   
   **Notes for maintainers**
   
   - Minor F-02: 
`fe/fe-core/src/test/java/org/apache/doris/nereids/rules/rewrite/PartitionPrunerTest.java:156-160`
 retains the old clamp-to-transition fixture. Under shifted-gap semantics its 
target is unreachable; mirror the corrected SQL fixture with source upper 
`2023-03-10 08:10:00.900000 +00:00` and target `2024-03-10 07:30:00.100000 
+00:00`. This is nonblocking test quality; the SQL regression covers the valid 
matching-row case.
   - Prior F-01 is fixed by upstream at 
`be/src/core/value/timestamptz_value.cpp:173-175`: the output conversion reuses 
`lookup.pre` instead of doing another civil lookup.
   
   <sub>Reviewed locally with the `doris-repo-review` pipeline. Repository 
policy may accept this receipt for the matching commit; it is not a human 
Apache approval.</sub>
   <!-- doris-repo-review:v1:end -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to