CalvinKirs commented on PR #70453:
URL: https://github.com/apache/doris/pull/70453#issuecomment-6910993604
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#70453
commit: e1daff182e2db79bd21f3cc78f04e2efc993cc0a
base: 42b148bac33f798edc9f8ae984a462b1b4a4f472
reviewed_at: 2026-11-16T16:11+08:00
reviewer: CalvinKirs
model: gpt-6.1-sol
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
- All 24 changed files and all 17 review checkpoints were covered.
Re-reviewed the current merge head; all changed files match the previously
reviewed implementation. No remaining findings.
- Review traced session/account separation, frozen policy role scopes, all
10 RPC snapshot senders, native whole-identity copying and detached
authorization callbacks. Optional Thrift field 4 is free on the current
maintained release branches; full role propagation requires upgraded FE and BE.
- Prior review records 184 selected FE tests across 21 classes (including 29
Flight metadata cases) and Checkstyle passing. These historical checks were not
rerun during this read-only review; native BE execution, live
authentication-plugin integration and mixed-version deployment remain
unverified.
<sub>Reviewed locally with the `doris-repo-review` pipeline (a local port of
`.github/workflows/code-review-runner.yml`). This is not a CI status
check.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]