stinger1206 commented on PR #67720: URL: https://github.com/apache/doris/pull/67720#issuecomment-6891441214
Hi, I've addressed the review comments and pushed two additional commits. - Marked `_parse_footer()` and its helper `_write_error_file()` const, with a comment explaining the concurrent parsing behavior. - Added a regression test verifying that repeated footer accesses refresh the LRU order. - Added a test covering footer lifetime and cache accounting across eviction and reload. All 8 `SegmentFooterCacheTest` tests passed locally under ASAN, including the two new tests. The full BE UT suite is left to CI. Regarding the cache-pressure concern, the tests confirm that a footer remains valid when held by a reader after cache eviction, while the cache's memory charge is released. The current implementation may re-parse the footer in this situation. I haven't been able to run a representative performance comparison against #69811. Would the regression coverage be sufficient to proceed, or could the maintainers help with the benchmark? The changes are ready for another review. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
