924060929 commented on code in PR #70397:
URL: https://github.com/apache/doris/pull/70397#discussion_r4548434224
##########
fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVRelationManager.java:
##########
@@ -79,6 +83,45 @@ public Set<BaseTableInfo> getMtmvsByBaseView(BaseTableInfo
table) {
return viewMTMVs.getOrDefault(table, ImmutableSet.of());
}
+ /** Only discard local rewrite plans; replay must not refresh an MV or
load external metadata. */
+ public void invalidateRewriteCaches(String catalog, String db, String
table) {
+ Set<BaseTableInfo> affected = Sets.newHashSet();
+ if (table != null) {
+ BaseTableInfo base = new BaseTableInfo(new TableNameInfo(catalog,
db, table));
Review Comment:
This finding is valid for the reviewed
0f2f1e9fe3539709fb3c211f005522aaa8fbdced, but was already repaired in
a713b8585cb2491c295421fd34e85935bebfae9d. GitHub had not synchronized this PR's
head with its source branch; closing and immediately reopening the same PR has
now updated the head to that repair commit. The invalidation key is constructed
directly from canonical metadata strings, bypassing TableNameInfo's global
SQL-name normalization. The regression covers retained mixed-case external
names with global normalization enabled/disabled and verifies both
rewrite-cache variants are cleared. Validation already completed on this
unchanged commit: 72 focused FE tests passed, ./build.sh --fe passed (UI
disabled), and Checkstyle reported zero violations. No additional source change
was necessary for this duplicate finding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
