github-actions[bot] commented on code in PR #69765:
URL: https://github.com/apache/doris/pull/69765#discussion_r4546001142
##########
fe/fe-core/src/main/java/org/apache/doris/clone/PartitionRebalancer.java:
##########
@@ -228,6 +228,10 @@ private boolean buildClusterInfo(LoadStatisticForTag
clusterStat, TStorageMedium
continue;
}
+ if (clusterStat.isMoveIncluded(move)) {
Review Comment:
[P2] Scope included-move markers to the storage medium
If an SSD balance move is waiting for a slot when ALTER/cooldown changes its
partition to HDD, the next snapshot projects it into HDD counts when both BEs
support HDD. This medium-blind check also skips it while reconciling the old
SSD cache. The pending context then receives HDD in
TabletScheduler.scheduleTablet; completeSchedCtx misses its entry in the HDD
cache, and failure cleanup invalidates HDD only, leaving the SSD entry alive.
For example, two one-replica tablets on A and none on B, with one stale A->B
entry, now appear as HDD counts 1/1, suppressing real balancing until the
default 600-second TTL. Reject cache/current-medium mismatches before this fast
path and associate included markers with the medium whose counts incorporated
them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
