hello-stephen opened a new pull request, #70486: URL: https://github.com/apache/doris/pull/70486
### Background The comment workflow routes `run buildall` to the applicable TeamCity pipelines. Performance is optional and is also available through the explicit `run performance` command on master. ### What problem does this PR solve? Issue Number: None Related PR: #70459 (introduced the current comment routing) PR Type: Bugfix Problem Summary: `run buildall` currently includes Performance. Its temporary validation configuration rejects general PR submissions, causing the comment workflow to fail after the other pipelines have already been queued. Make Performance explicit-only so aggregate runs do not attempt to submit it. ### Details - **Frequency:** Master `run buildall` requests with Performance-related file changes. - **Root cause:** The Performance step condition includes both `performance` and `buildall`. - **Why existing tests missed it:** Existing tests cover parsing and per-file selection, but do not execute the GitHub Actions step condition for aggregate requests. - **Fix:** Change the single step condition to require `COMMENT_TRIGGER_TYPE == 'performance'`. - **Other paths and branches:** Retain the positive master-only condition, file selection, repeat count, authentication and `skip buildall`. Other pipeline steps are unchanged. - **Behavior change:** `run buildall` no longer triggers Performance. `run performance` remains its explicit command, subject to the existing branch and file checks. ### Testing - `actionlint .github/workflows/comment-to-trigger-teamcity.yml` passed. - All 26 existing shell/workflow tests passed. - `git diff --check` passed. - Confirmed the diff changes only the Performance step condition. Live comment behavior can be verified after merge into the default branch. ### Release note None. ### Check List (For Author) - Behavior changed: Yes (see Details) - Does this need documentation: No - Pre-submission status: Partially verified: local checks passed; post-merge comment execution remains pending. ### AI Disclosure - Tool: Codex - Generated: One workflow condition and this description. - Human review: Pending. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
