gavinchou commented on code in PR #70006:
URL: https://github.com/apache/doris/pull/70006#discussion_r4535321991
##########
cloud/src/meta-service/meta_service_helper.h:
##########
@@ -222,28 +333,29 @@ void finish_rpc(std::string_view func_name,
brpc::Controller* ctrl, const Reques
Response* res) {
if constexpr (std::is_same_v<Response, CommitTxnResponse>) {
LOG(INFO) << "finish " << func_name << " remote_caller=" <<
ctrl->remote_side()
- << " original_client_ip=" << req->request_ip()
- << " response=" << res->ShortDebugString();
- } else if constexpr (std::is_same_v<Response, GetRowsetResponse>) {
+ << " original_client_ip=" << req->request_ip() << " db_id="
<< req->db_id()
+ << " txn_id=" << req->txn_id() << " status=" <<
res->status().ShortDebugString()
+ << " txn_status=" << res->txn_info().status() << "
table_ids=["
+ << fmt::format("{}", fmt::join(res->table_ids(), ",")) << "]"
+ << " partition_ids=[" << fmt::format("{}",
fmt::join(res->partition_ids(), ","))
+ << "] versions=[" << fmt::format("{}",
fmt::join(res->versions(), ",")) << "]"
+ << " lazy_commit=" << res->is_lazy_commit()
+ << " lazy_commit_incomplete=" <<
res->is_lazy_commit_incomplete()
+ << " tso_fence=" << res->tso_fence();
+ } else if constexpr (std::is_same_v<Response, GetRowsetResponse> ||
+ std::is_same_v<Response, GetVersionResponse> ||
Review Comment:
behavior chagned.
get version is a highfrequent RPC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
