raghav-reglobe commented on PR #69222:
URL: https://github.com/apache/doris/pull/69222#issuecomment-6657018044
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#69222
commit: 4e2bcb1d60f0ccb0f4b1b6c65afdd735adf45305
base: 9cb2d8a5e9a96b65647107a1e9bfd9237e860660
reviewed_at: 2026-11-05T17:08+05:30
reviewer: raghav-reglobe
model: claude-fable-5-1
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 2
converged: true
```
**Notes for maintainers**
- Reviewed as the unpushed candidate (15 commits on master 1503e390275c,
rebased) right before this force-with-lease push; the two earlier local runs of
this PR (head d083daf: REQUEST_CHANGES 1/1/13/4; candidate 4e84ad6:
REQUEST_CHANGES 1/0/2/1) were inherited and every one of their findings is
fixed at this head by content.
- Two design choices for the variant owners: (1) the typed
`parse_to_variant` call is produced by a sink-walk rewriter for every INSERT
shape (VALUES, SELECT, CTE, UNION, with and without a column list) instead of
bind-time typing; (2) the thrift carrier is `TVariantTemplatePath {pattern,
is_glob, is_decimal}` (renamed from `TVariantDecimalPath`, precision/scale
dropped — the BE resolves them from the column's template); the struct is
unreleased on every release branch (TScalarType's last field id is 7 on
master/4.2/4.1 and 5 on 4.0/3.1).
- This push's round: `withReturnType` builds the typed call outside
`keepFunctionSignature(true)` so the call's signature — and the template on the
wire — reaches the BE on every rewrite path; an array nested inside an array
stays off every declared path; the test pins `call.getDataType()`; clang-format
16 on four test statements.
- Not verified locally: no build and no test run (no JDK or BE toolchain on
the review machine); compile correctness and the test expectations were walked
by reading; the four `.out` files are the PR's own.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
