xylaaaaa commented on issue #69884: URL: https://github.com/apache/doris/issues/69884#issuecomment-6676464837
Review follow-up in `661bcbda52`: strengthen the Delta unit guard and stop pinning Iceberg's current CAST policy in the mixed HMS regression. This changes tests only. - The Delta connector test obtains the actual scan provider, verifies its `ConnectorPushdownOps` opt-in, and asserts that CAST pushdown is rejected. Removing the override or the interface opt-in will fail the module test without requiring the Docker regression environment. - Removed the mixed regression's `icebergPredicatePushdown=` and Iceberg `data_files: 1` assertions. The earlier isolation run documented current behavior, but that behavior should not be a permanent contract that blocks a future Iceberg correctness fix. - Kept the mixed JOIN / UNION ALL results, both table orders, both execution modes, and Delta's ordinary-predicate pruning checks. All 14 existing result blocks passed an ordinary rerun; the golden file is unchanged. - The Delta provider and common FE scan-node test classes passed all 32 tests (13 + 19), with no failures, errors or skips. Delta Checkstyle passed. The known Iceberg lossy-CAST issue remains in the local TODO for a separate fix. Test data is retained and the local services have been stopped again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
