raghav-reglobe commented on PR #70341:
URL: https://github.com/apache/doris/pull/70341#issuecomment-6681931497
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#70341
commit: ab11a1eeb678690bdb31e57a305139ea721d7a2e
base: f5c993f2c94acc5937a8e67c9659151251bdc941
reviewed_at: 2026-11-06T15:13+05:30
reviewer: raghav-reglobe
model: claude-fable-5-1
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 2}
rounds: 1
converged: true
```
**Notes for maintainers**
- `fe/fe-core/src/main/java/org/apache/doris/qe/ConnectPoolMgr.java:193-195`
— the counted-user entry is asserted rather than fallen back from: both entries
are written under `admissionLock`, and no route (production or test) reaches
`unregisterConnection` with a pool entry and no counted user.
- `fe/fe-core/src/main/java/org/apache/doris/qe/ConnectPoolMgr.java:168-173`
— the refusal now always carries `User current: N`; every consumer in the tree
matches a prefix, and both `arrow_flight_sql_p0` quota suites pin the segment
at their own limit.
- The accounting model is unchanged: a connection that changed user is still
counted against the user it logged in as, never against the new one
(pre-existing behaviour, out of this PR's scope).
- No rolling-upgrade or wire concern: in-memory session state only.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
