Gabriel39 commented on code in PR #70319: URL: https://github.com/apache/doris/pull/70319#discussion_r4489270153
########## contrib/apache-orc: ########## @@ -1 +1 @@ -Subproject commit be0f1b73a7aeb78824a03e0dcb692c50a176d513 +Subproject commit 5962bb071d6345cc29c5353d64d85a203525e4d9 Review Comment: Fixed in 47c223521c4. The x86-only guard around `add_thirdparty(deflate)` has been removed, matching master's dependency configuration. The existing thirdparty build already supplies libdeflate for all architectures; the adjacent comment records ORC's requirement. Validation used the branch's actual CMake dependency configuration: `aarch64` and `arm64` both reproduced missing libdeflate symbols before the change, while the x86 controls linked successfully. After the change, all four configurations linked and passed a DEFLATE round trip. These are host-native x86_64 probes with architecture dependency selection, not native ARM64/full BE builds; full build coverage remains for CI. The PR-affected C++ files also passed clang-format 16. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
