github-actions[bot] commented on code in PR #70176:
URL: https://github.com/apache/doris/pull/70176#discussion_r4489262190
##########
thirdparty/build-thirdparty.sh:
##########
@@ -1346,14 +1345,25 @@ build_arrow_adbc() {
-o "${TP_INSTALL_DIR}/lib64/libadbc_driver_jni.so" \
"${TP_INSTALL_DIR}/lib64/libadbc_driver_manager.a"
Review Comment:
[P1] Install or provide Go before the patched Flight build
The Linux branch now exits at `command -v "${go_cmd}"` when Go is absent,
and then requires Go 1.25+ to build `libadbc_driver_flightsql.so`. The
supported build images invoked by this script (`docker/compilation/Dockerfile`,
`docker/compilation/arm/Dockerfile`, and `Dockerfile.gcc10`) do not install Go
or set `GO_CMD`, so their `build-thirdparty.sh` step fails deterministically
after this change. Add a pinned Go toolchain to those images (or make the build
use a supplied artifact) and verify the required module/toolchain version
before invoking the build.
##########
fe/fe-core/src/main/java/org/apache/doris/arrowflight/FlightSqlSchemaHelper.java:
##########
@@ -168,7 +168,7 @@ protected static byte[] getSerializedSchema(List<Field>
fields) {
*/
public void setParameterForGetTables(CommandGetTables command) {
includeSchema = command.getIncludeSchema();
- catalogFilterPattern = command.hasCatalog() ? command.getCatalog() :
"internal";
+ catalogFilterPattern = command.hasCatalog() ? command.getCatalog() :
null;
dbSchemaFilterPattern = command.hasDbSchemaFilterPattern() ?
command.getDbSchemaFilterPattern() : null;
Review Comment:
[P1] Preserve dotted raw schema names in table metadata lookups
This call deliberately emits raw external database names, but `getTables()`
then passes each one to `FrontendServiceImpl.listTableStatus()` and
`describeTables()`. Those service paths still call
`InfoSchemaDb.getDbNameFromMysqlTableSchema()`, which splits every non-internal
name on `.`; a valid external database such as `a.b` is looked up as `b`, so
GetSchemas advertises it while GetTables returns no rows (and include-schema
requests fail the same way) whenever `show_full_dbname_in_info_schema_db` is
enabled. Carry the raw-schema mode through these calls or bypass the inverse
transform for Flight metadata, and add a dotted external-database regression.
##########
fe/fe-connector/fe-connector-adbc/src/main/java/org/apache/doris/connector/adbc/AdbcConnectorMetadata.java:
##########
@@ -69,8 +69,7 @@ public class AdbcConnectorMetadata implements
ConnectorMetadata {
private final AdbcMetadataCache cache;
/**
- * @param dialect resolved lazily, because only the {@code executeSchema}
fallback needs it and
Review Comment:
[P1] Avoid recursive GetObjects discovery when Doris identity is unavailable
When the vendor probe returns `NOT_IMPLEMENTED`, this branch sends an
unscoped ADBC `GetObjects` request. The same PR changes Flight's omitted
catalog filter from `internal` to all catalogs, so a Doris Flight endpoint that
lacks `GetInfo(VENDOR_NAME)` now enumerates the ADBC catalog that is waiting
for this response and recursively re-enters metadata loading. That makes SHOW
DATABASES/TABLES fail or hang on older/compatible Doris Flight servers;
`sql_dialect=doris` does not change this branch. Keep an explicit source-scoped
Doris metadata path or preserve a non-recursive fallback, and cover a Doris
server with SQL-info unsupported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
