Gabriel39 commented on PR #69779:
URL: https://github.com/apache/doris/pull/69779#issuecomment-6653006950
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#69779
commit: e846a7d936b4fc85ad0e915c1d2e755a6b1a3330
base: b2164ff1bacd3e467fd29f443ef9c03faa899658
reviewed_at: 2026-11-05T16:08+08:00
reviewer: Gabriel39
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
- `be/src/io/cache/cached_remote_file_reader.cpp:1450` — Rechecked the
previously reported inflight regression: all memory-first write policies now
delegate before disk-cache metadata locking, including zero-budget reads after
async writes are disabled.
- `be/src/io/cache/file_cache_io_adaptor.cpp:72` — Rechecked mixed-size and
sparse/bursty recovery: pending probe turns retain their observed gap until
admission, then rotate and reset; the shared time, request-count and in-flight
limits remain intact.
- `be/test/io/cache/cached_remote_file_reader_test.cpp:2974` — The opt-in
fast-local benchmark now accounts for bounded remote probes instead of
asserting zero remote requests.
- Source-only review covered all 22 changed files and reconfirmed the
earlier dismissals. No builds, tests or benchmarks were executed during this
review; author-reported validation was treated as background evidence.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
