SaintBacchus commented on code in PR #16941:
URL: https://github.com/apache/doris/pull/16941#discussion_r1113789878
##########
be/src/exec/es/es_scroll_parser.cpp:
##########
@@ -169,6 +171,49 @@ static Status get_int_value(const rapidjson::Value& col,
PrimitiveType type, voi
return Status::OK();
}
+template <typename T, typename RT>
+static RT get_date_value_int(const rapidjson::Value& col, PrimitiveType type,
bool is_date_str) {
+ const std::string& val = col.GetString();
+ size_t val_size = col.GetStringLength();
+
+ vectorized::DateV2Value<T> dt_slot;
+ if ((is_date_str && !dt_slot.from_date_str(val.c_str(), val_size)) ||
Review Comment:
```suggestion
if ((is_date_str && !dt_slot.from_date_str((static_cast<const
std::string>(col.GetString()).c_str(), col.GetStringLength())))) ||
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
