github-actions[bot] commented on code in PR #69671:
URL: https://github.com/apache/doris/pull/69671#discussion_r4431101790
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/scan/PluginDrivenScanNode.java:
##########
@@ -1284,6 +1290,7 @@ protected void convertPredicate() {
scanNodeProperties = null;
cachedPropertiesResult = null;
filteredToOriginalIndex = null;
+ partitionProofConjuncts = null;
}
/**
Review Comment:
[P2] Pin the plugin TCCL for partition-proof callbacks
`setScanParams` calls `ConnectorScanRange.getPartitionEnforcedConjuncts`
after the `planScan` TCCL scope has ended. In batch mode, `SplitProducer`
restores the worker TCCL before `createScanRanges` reaches this call. Iceberg's
implementation executes `PartitionSpecParser`/`ResidualEvaluator` on
child-loaded plugin objects, so an isolated connector can resolve parent-loader
helpers and fail range generation with a classloader `ClassCastException`. Run
the connector-range callback sequence (including this proof call and
`populateRangeParams`) inside `onPluginClassLoader` on both paths, and restore
the caller TCCL afterward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
