github-actions[bot] commented on code in PR #69488:
URL: https://github.com/apache/doris/pull/69488#discussion_r4430357754
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/RowLevelDmlCommand.java:
##########
@@ -154,7 +154,7 @@ public void run(ConnectContext ctx, StmtExecutor
stmtExecutor) throws Exception
public Plan getExplainPlan(ConnectContext ctx) {
Review Comment:
[P1] Guard write-only defaults in delete-only MERGE
`pinWriteSchema` marks `connectorDeleteTargets` only for
`RowLevelDmlOp.DELETE`. A valid `MERGE` with no insert/update branch (for
example, `WHEN MATCHED THEN DELETE`) is dispatched as `RowLevelDmlOp.MERGE`,
even though its sink writes no row values. Its `ON` predicate therefore lets
`RewriteDefaultExpression` replace `DEFAULT(t.c)` with the pinned Iceberg
write-default; with `c` defaulting to 35, `... ON t.id = s.id AND t.c =
DEFAULT(t.c) WHEN MATCHED THEN DELETE` deletes rows whose `c` is 35. Treat an
all-delete/no-insert MERGE as a delete target (including EXPLAIN), or reject
this DEFAULT use, and add coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
