Gabriel39 opened a new pull request, #69906:
URL: https://github.com/apache/doris/pull/69906

   ### What problem does this PR solve?
   
   Issue Number: None
   
   Related PR: None
   
   Doris bundles Brotli 1.0.9, which is affected by 
[CVE-2026-111497](https://github.com/google/brotli/releases/tag/v1.0.10). The 
upstream decoder can mistake an invalid block switch for insufficient input, 
allowing an out-of-bounds write.
   
   Upgrade the bundled dependency to the upstream 1.0.10 security release and 
update its archive checksum. Align Arrow 24's internal Brotli version and 
SHA256 pin with the overridden archive; changing the Doris manifest alone 
causes Arrow's ExternalProject verification to fail. Apply that metadata patch 
with a separate marker so previously patched Arrow source trees also receive it.
   
   The fix requires rebuilding the relevant thirdparty libraries and relinking 
BE because the decoder is statically linked.
   
   ### Release note
   
   Upgrade bundled Brotli to 1.0.10 to include the upstream fix for 
CVE-2026-111497.
   
   ### Check List (For Author)
   
   - Test: Manual validation passed:
     - Official source archive MD5 and SHA256 verification; the source contains 
the upstream block-switch error fix.
     - Bash syntax and `git diff --check`.
     - Existing thirdparty download checksum and fallback tests.
     - Actual Brotli/Arrow companion download and extraction; patch application 
to previously patched Arrow sources and repeated invocation.
     - Patch dry-run against pristine Arrow 24 metadata.
     - Arrow 24's Brotli ExternalProject verification, build, and 
static-library installation in an isolated CMake harness. Confirmed the old 
SHA256 pin fails with the new archive before the patch, then passes after it.
     - Brotli 1.0.10 build and all 14 available upstream 
round-trip/compatibility tests with AddressSanitizer and 
UndefinedBehaviorSanitizer.
     - Full Doris and Arrow builds were not run locally; CI validation is 
requested.
   - Behavior changed: Yes. Builds use the patched Brotli decoder and updated 
Arrow dependency metadata.
   - Does this need documentation: No. This updates a bundled security 
dependency.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to