yujun777 commented on code in PR #69896:
URL: https://github.com/apache/doris/pull/69896#discussion_r4424004208
##########
be/src/storage/task/engine_publish_version_task.cpp:
##########
@@ -243,8 +243,14 @@ Status EnginePublishVersionTask::execute() {
auto rowset_meta_ptr = rowset->rowset_meta();
auto tablet_id = rowset_meta_ptr->tablet_id();
- if (_publish_version_req.base_tablet_ids.contains(tablet_id)) {
+ if (_publish_version_req.base_tablet_ids.contains(tablet_id)
+ || tablet->is_changelog_tablet()) {
Review Comment:
Fixed in 5bb280ef364. You are right that the changelog rowset is attached to
the base tablet's transaction info rather than committed as a tablet of its
own, so the `is_changelog_tablet()` branch never saw it; it is gone now. The
publish path collects the attached rowset of each base tablet and reports it
under its own tablet id after `token->wait()`, so a rowset that a
merge-on-write publication extends with changelog segments is counted with its
final row count.
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/analysis/AnalysisManager.java:
##########
@@ -28,6 +28,7 @@
import org.apache.doris.catalog.ScalarType;
import org.apache.doris.catalog.Table;
import org.apache.doris.catalog.TableIf;
+import org.apache.doris.catalog.TabletMeta;
Review Comment:
Fixed in 5bb280ef364: `TabletMeta` now follows `Tablet` in the import block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
