zhannngchen commented on code in PR #16987:
URL: https://github.com/apache/doris/pull/16987#discussion_r1113132461
##########
be/src/util/mem_info.cpp:
##########
@@ -97,6 +98,8 @@ void MemInfo::process_cache_gc(int64_t& freed_mem) {
freed_mem +=
StoragePageCache::instance()->get_page_cache_mem_consumption(segment_v2::DATA_PAGE);
StoragePageCache::instance()->prune(segment_v2::DATA_PAGE);
+ freed_mem += SegmentLoader::instance()->segment_cache_mem_consumption();
+ SegmentLoader::instance()->prune_all();
Review Comment:
It's too aggressive, we may just need to call `prune_all()` when full gc.
Segment cache is quite useful on accelerating queries and MoW index lookup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
