github-actions[bot] commented on code in PR #69839:
URL: https://github.com/apache/doris/pull/69839#discussion_r4411983124
##########
be/src/format_v2/column_mapper.cpp:
##########
@@ -1243,6 +1243,10 @@ static bool rewrite_in_struct_literal_predicate(
return true;
}
+// Defined with the other mapping-shape helpers below; needed when rewriting
table expressions to
+// file-local expressions (a slot with unmapped children cannot stand in for
the table value).
Review Comment:
[P1] Whole-struct predicates can still be evaluated on the physical value
before missing children are materialized. The new
`mapping_slot_has_unmapped_child` check only runs in the generic slot rewrite,
but `rewrite_binary_slot_literal_predicate`/`rewrite_in_slot_literal_predicate`
run first and the same-type cast wrapper branch also returns a rewritten file
slot directly. For an ID-less fallback root `s STRUCT<inner INT DEFAULT 0>`
with physical `inner=5`, `s = STRUCT(0)` (or an equivalent IN/runtime-filter
expression) is localized against `5` and filters the row, while the finalized
table value is `{inner:0}` and should match. Apply the partial-root check to
every specialized rewrite path and add whole-struct binary/IN and
same-type-cast regressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
