Gabriel39 commented on code in PR #69852: URL: https://github.com/apache/doris/pull/69852#discussion_r4419678613
########## fe/fe-core/src/main/java/org/apache/doris/tablefunction/VectorSearchTableValuedFunction.java: ########## @@ -23,6 +23,7 @@ import org.apache.doris.thrift.TExternalSearchQuery; import org.apache.doris.thrift.TExternalSearchRequest; import org.apache.doris.thrift.TSearchVector; +import org.apache.doris.thrift.TVectorApproxMode; import org.apache.doris.thrift.TVectorElementType; Review Comment: Fixed in c6d4647cf75. `LanceScanNode.doInitialize()` now checks the initialized query backend policy before serializing the request. Explicit FAST/ACCURATE are rejected if any candidate BE is marked `isSmoothUpgradeSrc()`, with the requested mode, backend ID, and recovery action in the error. Omitted mode and explicit NORMAL remain compatible. The gate is independent of projected reader types and covers single- and multi-vector requests; it does not inspect unrelated BEs. Added regression coverage through real scan initialization: the test failed on the previous code because no rejection occurred, then passed after the fix. The 59 focused scan-node/TVF tests, clean FE Checkstyle, and clang-format 16 checks passed. The English/Chinese compatibility note is synchronized in apache/doris-website#4554, including the limitation that this marker-based guard cannot identify arbitrary unmarked older builds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
