CalvinKirs commented on PR #69835:
URL: https://github.com/apache/doris/pull/69835#issuecomment-6512840205
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#69835
commit: c3b37ae5084ebcbeb16a9387551f7612eeb9ffa6
base: 2a4191c1dc94e789e1725d6cb345f46c31a17272
reviewed_at: 2026-10-30T09:40+08:00
reviewer: CalvinKirs
model: gpt-6.1-sol
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
- Scope: 64 paths and all 17 checkpoints covered, with one converged round
and no findings. This reuses the completed full review at `00dfe97` and scope
review at `0e88246`: 60 unchanged paths were verified by exact content, four
retained test changes were freshly reviewed, and two paths leaving the PR were
checked independently.
- Validation: the author's focused `run-fe-ut.sh` completed with 47 tests
across four classes, zero failures/errors/skips, and Checkstyle enabled and
passed. Reviewers verified the archived XML evidence; they did not run builds,
tests, or a cluster. The five Iceberg cases affected only by removing two
constant assertions were compiled/style checked but were not rerun in that
focused selection.
- Known performance limitation: on real OSS, the 10,000-partition
fresh-catalog `SELECT * ... LIMIT 10` remains 3.77% slower by median and 4.05%
by mean in the disclosed comparison. Attribution is unresolved; this
source-review PASS does not certify absence of a performance regression or a
newly benchmarked package.
<sub>Reviewed locally with the `doris-repo-review` pipeline (a local port of
`.github/workflows/code-review-runner.yml`). This is not a CI status
check.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
