morningman commented on PR #67899: URL: https://github.com/apache/doris/pull/67899#issuecomment-6501076259
@hutiefang76 I rebased this branch onto the current master and added one commit on top, so it can go through CI and review: - Rebase: your two commits were cherry-picked onto master `2a4191c1dc9` with your authorship kept, and the two merge commits were dropped. The only conflict was the same `FlightSqlSchemaHelper` import block you resolved in 58c16ac902, resolved the same way. Your part of the diff is unchanged. - 2a31c4d622b brings over the end-to-end checks of branch-4.1 #68631, which implemented GetTableTypes there. `FlightSqlTableTypesTest#tableTypesAreSortedAndStableThroughFlightRpc` calls GetTableTypes three times through a real `FlightServer` and `FlightSqlClient`. `test_table_types_over_arrow_flight` sends the same GetFlightInfo -> DoGet calls from a plain Flight SQL client and then runs a query on the same session. The existing tests call `getStreamTableTypes()` directly or go through JDBC, so this sequence was not covered. Local results: `FlightSqlTableTypesTest`, `FlightSqlSchemaHelperTableTypesTest`, `FlightSqlSchemaHelperSerializedSchemaTest`, `FlightSqlNativeVariantTest`, `DorisFlightSqlProducerTest` and `FrontendServiceImplTest` pass (67 tests, Checkstyle included). All 21 suites under `arrow_flight_sql_p0`, including `test_table_types_over_arrow_flight` and `test_get_tables_schema`, pass on a local cluster built from this branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
