This is an automated email from the ASF dual-hosted git repository.
hello-stephen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new ee6969e3586 [fix](function) Fix HLL downsample constant column access
(#69799)
ee6969e3586 is described below
commit ee6969e35860c03747a5d2ab916689e99b94f77d
Author: Mryange <[email protected]>
AuthorDate: Thu Oct 29 14:56:17 2026 +0800
[fix](function) Fix HLL downsample constant column access (#69799)
Related PR: #69257, #69679
Problem Summary: The constant-expression API migration in #69679 missed
two calls introduced by #69257, breaking the BE build. Call
`ConstantExprResult::column_ptr()` when reading the HLL downsample
constant arguments.
---
be/src/exprs/function/function_datasketches_hll.cpp | 4 ++--
be/test/exprs/function/function_datasketches_hll_test.cpp | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/be/src/exprs/function/function_datasketches_hll.cpp
b/be/src/exprs/function/function_datasketches_hll.cpp
index f44dedd5e5d..15976660851 100644
--- a/be/src/exprs/function/function_datasketches_hll.cpp
+++ b/be/src/exprs/function/function_datasketches_hll.cpp
@@ -97,13 +97,13 @@ public:
// `10 + crc32('') % 2`, may not be evaluated in open either, then it
is read from the
// first row in execute.
if (context->is_col_constant(1)) {
-
RETURN_IF_ERROR(parse_lg_k(*context->get_constant_col(1)->column_ptr,
state->lg_k));
+
RETURN_IF_ERROR(parse_lg_k(*context->get_constant_col(1)->column_ptr(),
state->lg_k));
}
if (context->get_num_args() == 2) {
state->tgt_type = datasketches::HLL_4;
} else if (context->is_col_constant(2)) {
RETURN_IF_ERROR(
- parse_tgt_type(*context->get_constant_col(2)->column_ptr,
state->tgt_type));
+
parse_tgt_type(*context->get_constant_col(2)->column_ptr(), state->tgt_type));
}
context->set_function_state(scope, state);
return Status::OK();
diff --git a/be/test/exprs/function/function_datasketches_hll_test.cpp
b/be/test/exprs/function/function_datasketches_hll_test.cpp
index 9e29a423ad5..eaab1871cae 100644
--- a/be/test/exprs/function/function_datasketches_hll_test.cpp
+++ b/be/test/exprs/function/function_datasketches_hll_test.cpp
@@ -214,14 +214,14 @@ protected:
const auto args = block.get_columns_with_type_and_name();
DataTypes types;
ColumnNumbers indexes;
- std::vector<std::shared_ptr<ColumnPtrWrapper>> constants;
+ std::vector<std::shared_ptr<ConstantExprResult>> constants;
bool nullable = false;
for (size_t i = 0; i < args.size(); ++i) {
types.push_back(args[i].type);
indexes.push_back(i);
nullable |= args[i].type->is_nullable();
constants.push_back(constants_in_open &&
is_column_const(*args[i].column)
- ?
std::make_shared<ColumnPtrWrapper>(args[i].column)
+ ?
std::make_shared<ConstantExprResult>(args[i].column)
: nullptr);
}
auto result_type = nullable ? make_nullable(remove_nullable(types[0]))
: types[0];
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
