morningman commented on PR #69711: URL: https://github.com/apache/doris/pull/69711#issuecomment-6469712962
Addressed the third review round in `3c2a8e9cb87`. Per finding: - 4398396743 (P2, ORC and Parquet TIME keys): fixed. Under the STRING placeholder the FE sends for an Iceberg TIME, a `BIGINT` (ORC) / `TIMEV2` (Parquet) key pair compares as `TIMEV2(6)`, the `BIGINT` side converted exactly as microseconds from midnight rather than through a SQL cast. Before this PR such a pair only matched NULL tombstones, see the thread. - 4398396750 (P2, a placeholder's text default): fixed. A non-NULL default behind the placeholder is parsed in the tombstones' type with the strict comparison cast. This also fixes `AncestorNullDefaultExpr::open()`, which never opened its children, so a default cast below it aborted the BE. BE unit tests on macOS arm64 (ASAN), `IcebergV2ReaderTest.*:*EqualityDelete*:*ColumnMapper*:*EvolutionCast*:*TableReader*`: 526 of 526 pass, including the two new cases. Removing the TIME pair rule or the default parsing, or using a SQL cast for the ORC TIME, fails the new tests; leaving the children unopened aborts. clang-tidy passes on the changed lines, and the touched TUs were syntax-checked against the PR head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
