jacktengg opened a new pull request, #69774:
URL: https://github.com/apache/doris/pull/69774
### What problem does this PR solve?
Issue Number: N/A
Related PR: N/A
Problem Summary: With enable_new_type_coercion_behavior disabled, comparing
TIMESTAMPTZ values with different scales falls through to the legacy DATETIME
comparison type. String literals are parsed at their own fractional precision,
so deleting from a TIMESTAMPTZ(6) unique-key table with an unscaled timestamp
literal fails with a TIMESTAMPTZ-to-DATETIME cast error, even if no row
matches. Reuse the existing TIMESTAMPTZ common-type rule in legacy comparisons
to preserve the higher precision and UTC representation. Add coverage for every
scale pair, string literals, both coercion modes, timezone offsets, boundary
years, and microsecond-sensitive DELETE and IN predicates.
### Release note
Fix TIMESTAMPTZ comparisons and DELETE predicates involving different
fractional precisions when enable_new_type_coercion_behavior is disabled.
### Check List (For Author)
- Test: Unit Test / Regression test / Manual test
- run-fe-ut.sh: TypeCoercionUtilsTest and TypeCoercionMatrixTest, 75
tests passed.
- build.sh --fe: build and Checkstyle passed.
- run-regression-test.sh: test_timestamptz_delete_scale_coercion and
test_timestamptz_delete_uniq_key passed.
- Generated regression expectations using run-regression-test.sh -genOut
and verified identical results in both modes.
- Reproduced the reported SQL error before the fix and verified it
succeeds after the fix.
- Behavior changed: Yes, legacy comparisons retain TIMESTAMPTZ precision
instead of failing a DATETIME cast.
- Does this need documentation: No
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
