CalvinKirs opened a new pull request, #69740:
URL: https://github.com/apache/doris/pull/69740
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: `skip_localhost_auth_check` defaults to `true`, allowing
`root` and `admin` MySQL logins from `127.0.0.1` to return before normal
password validation. The field comment already documents a `false` default.
Set the default to `false`, so localhost logins follow normal password
validation when no explicit override is configured. Retain `@ConfField(mutable
= false)`: `ADMIN SET FRONTEND CONFIG` continues to reject runtime changes.
Operators can still explicitly enable the option in startup configuration and
restart FE for password recovery.
### Release note
Change the FE `skip_localhost_auth_check` default to `false`. Localhost
`root` and `admin` MySQL logins now follow normal password validation by
default. The configuration remains non-mutable and requires an FE restart to
change.
### Check List (For Author)
- Test
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test
- [x] No need to test or manual test. Explain why:
- [x] Other reason: This changes one configuration default and adds
no execution logic. No FE build, unit tests, or runtime tests were run.
Validation:
- Checkstyle passed for the modified `Config.java` with zero violations.
- `git diff --check` passed.
- Source inspection confirmed `mutable = false` and the existing runtime
setter rejection.
- Behavior changed:
- [ ] No.
- [x] Yes. Disable the localhost password-validation bypass by default.
- Does this need documentation?
- [x] No. The existing field comment already documents a `false` default.
- [ ] Yes.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
