zhannngchen commented on code in PR #16938:
URL: https://github.com/apache/doris/pull/16938#discussion_r1112581320
##########
be/src/vec/olap/vgeneric_iterators.cpp:
##########
@@ -374,6 +374,11 @@ Status VUnionIterator::init(const StorageReadOptions&
opts) {
return Status::OK();
}
+ // we use back() and pop_back() of std::vector to handle each iterator,
Review Comment:
My bad, I understand the context wrong at the beginning. I thought why you
need to reverse the iterator here because the input is reversed, so I suggested
that we should adjust the input.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
