englefly opened a new pull request, #69687:
URL: https://github.com/apache/doris/pull/69687

   ### What problem does this PR solve?
   
   Issue Number: close #xxx
   
   Related PR: #xxx
   
   Problem Summary:
   test_pushdown_explain asserts that the plan of
   select count(1) - count(lo_shipmode) from test_lineorder contains
   pushAggOp=COUNT. lo_shipmode is NOT NULL, so this expression is always 0.
   RewriteSimpleAggToConstantRule can replace both counts with the table row
   count from SimpleAggCacheMgr and fold the whole expression into a constant
   VUNION plan before the scan-level COUNT pushdown happens. The row count is
   loaded asynchronously, so whether the rule fires depends on whether the cache
   has been warmed by the preceding statements. The assertion can therefore pass
   or fail depending on statement timing, and the failure can land on the second
   or the third count assertion.
   
   Master's query_p0/explain/test_pushdown_explain.groovy already disables this
   rule before the count assertions. This patch aligns the branch-4.1 test with
   master so the case keeps testing the COUNT pushdown path instead of the
   metadata constant rewrite. The query result is unchanged; this is a test
   stabilization, not a planner behavior change.
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: 
https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should 
merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to