hubgeter opened a new pull request, #69680:
URL: https://github.com/apache/doris/pull/69680
### What problem does this PR solve?
Issue Number: N/A
Related PR: #69188, #69449
Problem Summary:
Port the fixes from #69188 and #69449 to branch-4.2, adapting each fix to
the legacy FE architecture rather than cherry-picking the master connector
implementation.
- #69188: `INSERT OVERWRITE ... PARTITION (id = 2)` now resolves the static
partition name to the top-level source column of an identity partition field,
matching Spark and the FE binder. Renamed identity fields are rejected with the
usable source column, validation uses the statement-pinned writer schema/spec,
and the execution context is rewritten to partition-field keys before both the
BE sink and commit overwrite filter consume it.
- #69449: `CREATE BRANCH ... RETAIN <time>` now sets the branch reference
`max-ref-age-ms`, while `WITH SNAPSHOT RETENTION <time>` sets
`max-snapshot-age-ms`, matching Iceberg Spark.
One original PR is represented by one commit:
- `333a2a18b38` - [fix](iceberg) Fix static partition writes for renamed
identity fields (#69188)
- `fb14c5a71ee` - [fix](iceberg) Map branch retention times correctly
(#69449)
### Release note
Fix Iceberg static partition writes for renamed identity partition fields
and map branch `RETAIN`/snapshot retention times correctly.
### Check List (For Author)
- Test
- [x] Regression test
- [x] Unit Test
- [x] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason
- Manual test detail: changed FE main and test sources compile with Java 8
target; 95 focused tests pass (`IcebergUtilsTest`, `IcebergTransactionTest`,
`IcebergExternalTableBranchAndTagTest`, `IcebergStaticPartitionLiteralTest`);
`fe-core` checkstyle reports 0 violations. Regression case TC39 is added for
renamed identity static overwrite. The local external-docker regression suite
is expected to run through `run buildall`.
- Behavior changed:
- [ ] No.
- [x] Yes.
- Does this need documentation?
- [x] No.
- [ ] Yes.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
