zddr commented on code in PR #16957:
URL: https://github.com/apache/doris/pull/16957#discussion_r1112464483
##########
fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/RoleManager.java:
##########
@@ -181,17 +183,27 @@ public Role createDefaultRole(UserIdentity userIdent)
throws DdlException {
}
public Role removeDefaultRole(UserIdentity userIdent) {
- return roles.remove(getUserDefaultRoleName(userIdent));
+ Role role = roles.remove(getUserDefaultRoleName(userIdent));
+ if (role == null) {
Review Comment:
Repetitive logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
