airborne12 commented on code in PR #68607: URL: https://github.com/apache/doris/pull/68607#discussion_r4373468670
########## be/test/storage/index/inverted/snii/testdata/compatibility_corpus/english_docs.expect: ########## @@ -0,0 +1,44 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# sample=english_docs doc_count=20 lower_case=true parser=english +5 hello 0 0,10,18,19 0 4,5,6,11 +5 hello%20world 0 0,10,18,19 0 4,5,6,11 +5 nonexistent 0 0 4,5,6,11 +5 the 0 2 0 4,5,6,11 +5 重复 0 0 4,5,6,11 +5 %1fhidden 0 12 0 4,5,6,11 +5 prefix 0 14 0 4,5,6,11 +5 tok 0 16 0 4,5,6,11 +5 0 0 4,5,6,11 +6 hello%20world 0 0,10,19 0 4,5,6,11 +6 again%20and 0 10 0 4,5,6,11 +6 alpha%20beta%20gamma 0 15 0 4,5,6,11 +6 hello%20nonexistent 0 0 4,5,6,11 +7 hello%20world -6001 0 4,5,6,11 Review Comment: Fixed in `9df654a58784172203aab289d4068f2158cb22f0`. The current contract supports the finding: `SniiIndexSource::open_terms` returns `Status::NotSupported` when positions are requested from a docs-only image. The phrase engine propagates that status, and `SniiIndexReader::_run_leaf` preserves `NOT_IMPLEMENTED_ERROR (3)` at its exception boundary. The existing `SniiIndexSourceTest.PositionsNeedAPositionedIndex` also checks this code and passed in BE UT build 1079928. Updated exactly the nine affected phrase/phrase-prefix status cells from `-6001` to `3`. All eight `.idx` images, all document/NULL results, and the other 162 query records are unchanged. The independent equality/posting audit also passes. Full merged-tree clang-format, FE Checkstyle, English, and BE build-hygiene checks pass. The corpus discovery failure is fixed in the same commit so CI can reach these observations. The full public-reader corpus test was not run locally; its new CI result remains pending. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
