github-actions[bot] commented on code in PR #69591:
URL: https://github.com/apache/doris/pull/69591#discussion_r4372006062
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindSink.java:
##########
@@ -701,6 +702,10 @@ private Plan
bindTVFTableSink(MatchingContext<UnboundTVFTableSink<Plan>> ctx) {
"INSERT INTO TVF only supports local/s3/hdfs, but got: " +
tvfName);
}
+ if (tvfName.equals(LocalTableValuedFunction.NAME)) {
+ LocalTableValuedFunction.checkAccess(ctx.connectContext);
Review Comment:
[P2] Opt the existing LOCAL sink test into the new gate
`BindTVFTableSinkTest.duplicateOutputNamesKeepDistinctPositions()` still
analyzes a valid `INSERT INTO local(...) SELECT 1 AS x, 2 AS x`, but its
fixture never sets `Config.enable_local_tvf`. With the new default of `false`,
this call to `checkAccess` now throws `LOCAL TVF is disabled` before the test
can inspect the sink or assert distinct output ExprIds, so the existing FE unit
test fails. Enable and restore the flag in that fixture (with the required
privileges), or use a remote sink for its backend-independent binding
assertions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
