jacktengg commented on code in PR #69271:
URL: https://github.com/apache/doris/pull/69271#discussion_r4333606500
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/util/TypeCoercionUtils.java:
##########
@@ -606,20 +600,20 @@ public static Expression
castIfNotSameTypeStrict(Expression input, DataType targ
}
}
- /** Cast a DATETIME-family value to TIMESTAMP_NS and abort on conversion
overflow. */
+ /** Cast a date-like value to TIMESTAMP_NS and abort on conversion
overflow. */
public static Expression
castIfNotSameTypeForTimeStampNsCoercion(Expression input, DataType targetType) {
if (hasTimeStampNsType(targetType)
- && hasTimeStampNsCompatibleDateTimeType(input.getDataType())) {
+ && hasOtherDateLikeType(input.getDataType())) {
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
