OIiveirra commented on code in PR #69032:
URL: https://github.com/apache/doris/pull/69032#discussion_r4332449126
##########
be/src/core/data_type_serde/data_type_varbinary_serde.cpp:
##########
@@ -66,7 +77,7 @@ class VarbinaryParquetConsumer final : public
ParquetFixedValueConsumer,
}
private:
- ColumnVarbinary& _column;
Review Comment:
已在
[44403d573b4](https://github.com/apache/doris/commit/44403d573b4f5331547f9b53c74801b923e74c3a)
拆成 `VarbinaryParquetConsumer` 和 `GeoParquetConsumer`，共用
`BinaryParquetConsumerBase`。空间校验仍在空间 SerDe，原 VARBINARY 路径不变。
##########
gensrc/thrift/HeartbeatService.thrift:
##########
@@ -67,6 +67,7 @@ struct TBackendInfo {
10: optional i64 be_mem // The physical memory available for use by BE.
// Reserved for the Paimon Rust reader and aligned with its branch-4.1
forward-port.
11: optional bool supports_paimon_rust_reader
+ 12: optional bool supports_spatial_types
Review Comment:
已在
[91e7761b42a](https://github.com/apache/doris/commit/91e7761b42a8f2c99565ebbce937f56865d1ea25)
删除空间兼容字段、心跳传递及两条协调器门禁。保留常量折叠保护，因为 FE 无法解码空间 PValues；中英文文档已同步。
##########
be/src/exprs/aggregate/aggregate_function_min_max_impl.h:
##########
@@ -135,6 +135,9 @@ AggregateFunctionPtr
create_aggregate_function_single_value(const String& name,
return creator_without_type::create_unary_arguments<
AggregateFunctionsSingleValue<Data<SingleValueDataFixed<TYPE_DECIMAL256>>>>(
argument_types, result_is_nullable, attr);
+ // Spatial states must own their WKB after the input block is released.
+ case PrimitiveType::TYPE_GEOMETRY:
Review Comment:
Fixed in
[e7add2369f6](https://github.com/apache/doris/commit/e7add2369f68e556d68ba8713ea0c4eb4479f6f1).
Unsupported spatial MIN/MAX_BY, TOPN_ARRAY, MULTI_DISTINCT_COUNT and
group-array set operations now fail in FE, including window DISTINCT rewriting
and late COUNT conversion. FE UT 21/21 and Iceberg generation/non-generation
regression 1/1 each pass, covering both kinds, nullable inputs and argument
positions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
