924060929 commented on code in PR #69298:
URL: https://github.com/apache/doris/pull/69298#discussion_r4321675710
##########
fe/fe-connector/fe-connector-iceberg/src/main/java/org/apache/doris/connector/iceberg/IcebergScanPlanProvider.java:
##########
@@ -2858,37 +2872,80 @@ private CloseableIterable<FileScanTask>
cacheBackedFileScanTasks(TableScan scan,
if (!ManifestEvaluator.forPartitionFilter(filterExpr, spec,
caseSensitive).eval(manifest)) {
continue;
}
- deleteFiles.addAll(manifestCacheGet(manifest, table, specsById,
statsQueryId).getDeleteFiles());
+ deleteFiles.addAll(manifestCacheGet(manifest, table,
statsQueryId).forScan(spec).getDeleteFiles());
Review Comment:
Fixed in b166253d264489a3ef7ef4b40a8f87245c9723c6. Acquire the
statement-wide budget before eager delete-index planning and use a common
admission/lifetime helper for actual delete and data reads. Cold
equality-delete field discovery uses the same budget too; cached-only results
do not wait on a permit. Cancellation is propagated rather than triggering an
SDK planning retry. Real SDK tests cover data/delete overlap at concurrency=1
for position deletes and equality-field discovery, cancellation during
admission, and owner/permit release on failure. All 1508 Iceberg tests ran with
zero failures/errors (one intentional live-test skip); FE build and Checkstyle
passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
