mrhhsg commented on PR #69288: URL: https://github.com/apache/doris/pull/69288#issuecomment-6283706669
<!-- autopilot-response --> Reviewed the current review state at head `be394b4675c2df72f939406ee66e724d52b195c2`. - `PRR_kwDOBfSlxs8AAAABTBibMA` (Code Review, COMMENTED): still the only review, and it reports no actionable findings. Its only optional note — extra null/container-value, multi-pair and const-shape combinations — is a coverage extension, not a defect; the changed path is already covered by the new BE rows and the ordered SQL cases, and the review traced the common implementation paths statically. No code change is needed. - `IC_kwDOBfSlxs8AAAABdoj4uw` (BE Regression && UT Coverage Report): informational coverage report for the same commit; no action required. - `IC_kwDOBfSlxs8AAAABdY8YwQ` (contribution checklist prompt): the PR description covers problem and reproduction, root cause in `FunctionJsonbModify::write_json_value`, the fix, behavior impact and tests. - `IC_kwDOBfSlxs8AAAABdY8eBA` (`/review`): the Code Review workflow completed for this head with no actionable finding. - `IC_kwDOBfSlxs8AAAABdZFJQA` (`run buildall`) and the following TPC-H / TPC-DS / ClickBench reports (`IC_kwDOBfSlxs8AAAABdbU2xA`, `IC_kwDOBfSlxs8AAAABdbhfWQ`, `IC_kwDOBfSlxs8AAAABdbnpOw`): benchmark runs, informational only. - `IC_kwDOBfSlxs8AAAABdmr-tg` (`run beut`), `IC_kwDOBfSlxs8AAAABdmsCYQ` (`run external`), `IC_kwDOBfSlxs8AAAABdmsGSw` (`run nonConcurrent`): pipeline trigger comments; no code action required. - `IC_kwDOBfSlxs8AAAABdn3jKg`, `IC_kwDOBfSlxs8AAAABdn9jiQ` and `IC_kwDOBfSlxs8AAAABdoQ2dA` (earlier BE UT / BE Regression && UT coverage reports): informational only. - The earlier `<!-- autopilot-response -->` comments (`IC_kwDOBfSlxs8AAAABdZD3VA`, `IC_kwDOBfSlxs8AAAABdmndXg`, `IC_kwDOBfSlxs8AAAABdn9izg`, `IC_kwDOBfSlxs8AAAABdoSkaw`): prior round summaries, kept for context. Verification this round: `FunctionJsonbTEST.*` was re-run on the head build and all 20 tests passed, including `JsonbModifyNestedMissingMemberKeepsFollowingSiblings`. There are no inline review threads on this PR, and the branch head is unchanged at `be394b4675c2df72f939406ee66e724d52b195c2`. Could a human reviewer take another look and approve if the change looks good? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
