morrySnow commented on code in PR #16855:
URL: https://github.com/apache/doris/pull/16855#discussion_r1109402276
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/RuntimeFilterGenerator.java:
##########
@@ -143,6 +144,14 @@ public PhysicalOlapScan
visitPhysicalOlapScan(PhysicalOlapScan scan, CascadesCon
return scan;
}
+ @Override
+ public PhysicalFileScan visitPhysicalFileScan(PhysicalFileScan scan,
CascadesContext context) {
Review Comment:
merge it with visitPhysicalOlapScan, use visitPhysicalRelation
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/RuntimeFilterPruner.java:
##########
@@ -145,6 +146,22 @@ public PhysicalOlapScan
visitPhysicalOlapScan(PhysicalOlapScan olapScan, Cascade
return olapScan;
}
+ @Override
+ public PhysicalFileScan visitPhysicalFileScan(PhysicalFileScan fileScan,
CascadesContext context) {
Review Comment:
ditto
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -555,6 +555,11 @@ public PlanFragment visitPhysicalFileScan(PhysicalFileScan
fileScan, PlanTransla
Utils.execWithUncheckedException(fileScanNode::init);
context.addScanNode(fileScanNode);
+ context.getRuntimeTranslator().ifPresent(
+ runtimeFilterGenerator ->
runtimeFilterGenerator.getTargetOnScanNode(fileScan.getId()).forEach(
+ expr ->
runtimeFilterGenerator.translateRuntimeFilterTarget(expr, fileScanNode, context)
+ )
+ );
Review Comment:
add RF translation to all scan node translator, thanks~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
