csun5285 opened a new pull request, #69315:
URL: https://github.com/apache/doris/pull/69315
### What problem does this PR solve?
Issue Number: N/A
Related PR: #64601
Problem Summary: Backport #64601 to branch-4.2. Queries that only need a
dictionary-encoded VARCHAR column's length, including empty-string comparisons
rewritten to length checks, may read only offsets. If the same column has a
storage delete condition, evaluating that condition against content-less values
can return deleted rows. Remove delete-condition columns from all_access_paths
so their predicates use fully materialized values.
Resolve the branch conflicts by preserving condition_cache_digest and
merging the two delete-column unit tests into the existing TabletReaderTest
fixture without changing its TopN tests. The regression suite and generated
expected output are unchanged from the source commit.
### Release note
Fix queries using string lengths or empty-string comparisons returning rows
excluded by storage delete conditions.
### Check List (For Author)
- Test: clang-format 16 via build-support/clang-format.sh and
build-support/check-format.sh passed for all three changed C++ files;
source/suite whitespace and conflict-preservation checks passed.
- Unit Test / Regression test: backported both unit tests and the
regression suite; not executed locally. An ASAN build was started with build.sh
--be -j 24 and stopped during first-time submodule initialization. Compilation
and runtime tests require CI validation.
- The generated .out file is byte-for-byte identical to #64601; trailing
tabs represent empty string values.
- branch-4.2 does not contain check-build-hygiene.sh or
run-clang-tidy.sh, so those scripts were unavailable.
- Behavior changed: Yes; delete-condition columns use a full read so deleted
rows remain filtered.
- Does this need documentation: No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
