morrySnow commented on code in PR #16819:
URL: https://github.com/apache/doris/pull/16819#discussion_r1108509567
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/implementation/LogicalTopNToPhysicalTopN.java:
##########
@@ -39,8 +39,9 @@ public Rule build() {
}
private List<PhysicalTopN<? extends Plan>> twoPhaseSort(LogicalTopN
logicalTopN) {
- PhysicalTopN localSort = new PhysicalTopN(logicalTopN.getOrderKeys(),
logicalTopN.getLimit(),
- logicalTopN.getOffset(), logicalTopN.getLogicalProperties(),
logicalTopN.child(0),
+ PhysicalTopN localSort = new PhysicalTopN(logicalTopN.getOrderKeys(),
+ logicalTopN.getLimit() + logicalTopN.getOffset(),
+ 0, logicalTopN.getLogicalProperties(), logicalTopN.child(0),
SortPhase.LOCAL_SORT);
Review Comment:
SortPhase in TopN still at the end of arg list
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
