HappenLee commented on code in PR #16841:
URL: https://github.com/apache/doris/pull/16841#discussion_r1108484218
##########
be/src/vec/functions/function_java_udf.cpp:
##########
@@ -194,6 +228,74 @@ Status JavaFunctionCall::execute(FunctionContext* context,
Block& block,
reinterpret_cast<int64_t>(data_col->get_raw_data().data);
\
env->CallNonvirtualVoidMethodA(jni_ctx->executor, executor_cl_,
executor_evaluate_id_, \
nullptr);
\
+ } else if (data_col->is_column_array()) {
\
+ ColumnArray* array_col = assert_cast<ColumnArray*>(data_col.get());
\
+ ColumnNullable& array_nested_nullable =
\
+ assert_cast<ColumnNullable&>(array_col->get_data());
\
+ auto data_column_null_map =
array_nested_nullable.get_null_map_column_ptr(); \
+ auto data_column = array_nested_nullable.get_nested_column_ptr();
\
+ auto& offset_column = array_col->get_offsets_column();
\
+ int increase_buffer_size = 0;
\
+ int32_t buffer_size =
JniUtil::IncreaseReservedBufferSize(increase_buffer_size); \
+ offset_column.reserve(num_rows);
\
+ offset_column.resize(num_rows);
\
Review Comment:
only do resize is enough？
##########
be/src/vec/functions/function_java_udf.cpp:
##########
@@ -194,6 +228,74 @@ Status JavaFunctionCall::execute(FunctionContext* context,
Block& block,
reinterpret_cast<int64_t>(data_col->get_raw_data().data);
\
env->CallNonvirtualVoidMethodA(jni_ctx->executor, executor_cl_,
executor_evaluate_id_, \
nullptr);
\
+ } else if (data_col->is_column_array()) {
\
+ ColumnArray* array_col = assert_cast<ColumnArray*>(data_col.get());
\
+ ColumnNullable& array_nested_nullable =
\
+ assert_cast<ColumnNullable&>(array_col->get_data());
\
+ auto data_column_null_map =
array_nested_nullable.get_null_map_column_ptr(); \
+ auto data_column = array_nested_nullable.get_nested_column_ptr();
\
+ auto& offset_column = array_col->get_offsets_column();
\
+ int increase_buffer_size = 0;
\
+ int32_t buffer_size =
JniUtil::IncreaseReservedBufferSize(increase_buffer_size); \
+ offset_column.reserve(num_rows);
\
+ offset_column.resize(num_rows);
\
+ *(jni_ctx->output_offsets_ptr) =
\
+ reinterpret_cast<int64_t>(offset_column.get_raw_data().data);
\
+ data_column_null_map->reserve(buffer_size);
\
+ data_column_null_map->resize(buffer_size);
\
Review Comment:
same to the up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
