mrhhsg commented on code in PR #68032: URL: https://github.com/apache/doris/pull/68032#discussion_r4301256880
########## be/src/io/fs/s3_file_writer.h: ########## @@ -21,6 +21,7 @@ #include <chrono> #include <cstddef> +#include <functional> Review Comment: Removed in 2f0938d0874: neither `S3FileWriter::abort()` nor a spill-side AbortMultipartUpload RPC is needed. The generic S3 writer sources and tests now match the PR base. Failed/discarded spill parts still drain in-flight uploads through writer destruction before prefix cleanup, without closing a broken part just to publish it. Incomplete multipart uploads are left to an explicitly configured `AbortIncompleteMultipartUpload` bucket lifecycle rule; completed objects still use normal prefix cleanup. The PR description and configuration comments document this prerequisite. Focused ASAN unit tests passed (47 tests); formatting, build hygiene and changed-line clang-tidy checks passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
